You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it turns out after applying Azure/autorest.go#520, the profileBuilder might not work (check the results here).
The tool will not automatically import the new uuid package, and therefore compile errors occur.
This PR fix the profileBuilder to let it scan the import statement and add them to the generated file when necessary.
What exactly is broken without this fix? I looked at the linked PR, the only failure I see is the "broken link detection" which looks unrelated.
I am not quite sure why this happens, but previously we rely on the programmatically invoked goimports to complete the import, such like the uuid package. But after we have switched the uuid to github.com/gofrs/uuid, it does not work anymore. Hence, it would not automatically import the github.com/gofrs/uuid package (in those are using uuid). I am not quite sure if this is related with the fact that the old uuid package always has an alias, ie, uuid "github.com/satori/go.uuid". Do you have any clue of this?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it turns out after applying Azure/autorest.go#520, the profileBuilder might not work (check the results here).
The tool will not automatically import the new uuid package, and therefore compile errors occur.
This PR fix the profileBuilder to let it scan the import statement and add them to the generated file when necessary.